Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHER] Packaging guidelines #77

Closed
michalszmidt opened this issue Dec 14, 2023 · 5 comments
Closed

[OTHER] Packaging guidelines #77

michalszmidt opened this issue Dec 14, 2023 · 5 comments
Labels
Suggestion All kinds of suggestions

Comments

@michalszmidt
Copy link

michalszmidt commented Dec 14, 2023

Hi,

thank you for developing this missing piece of KDE!

As a packager I could not create template file for Koi for Void Linux build system.
It doesn't recognize it as a cmake project.
I could not find any workaround for it except forking repo and setting src as top root of the project

I'm not expert but most cmake projects I saw had CMakeLists.txt in the root of the project. I guess this should fix it.

Could you tweak and move CMakeLists.txt to the top root of the project then create a tag 0.2.4.1?

Also I opened void-linux/void-packages#47761 so they could handle this scenario.

@MartinVonReichenberg
Copy link
Collaborator

MartinVonReichenberg commented Dec 15, 2023

Hello,

cmake -S ${srcdir}(name-version)/src/ -B ${builddir}/src/build/

Look at the AUR PKGBUILD file, it should be the same . . .

@MartinVonReichenberg
Copy link
Collaborator

So,
Did you succeed at Issue#47761 , @michalszmidt
?_?

@michalszmidt
Copy link
Author

michalszmidt commented Dec 18, 2023

EDIT:

It turned out that my test environment was weirdly broken and with help of void-linux team compilation passes now.

I'll tweak it more (add desktop files etc.) and open pull request for Koi to the official void repo! Thanks for your time.

@MartinVonReichenberg
Copy link
Collaborator

MartinVonReichenberg commented Dec 21, 2023

EDIT:

It turned out that my test environment was weirdly broken and with help of void-linux team compilation passes now.

I'll tweak it more (add desktop files etc.) and open pull request for Koi to the official void repo! Thanks for your time.

What desktop files?

All is mentioned in Koi/src/resources/(resources.qrc) and there is already a koi.desktop file inside Koi/src.

@michalszmidt
Copy link
Author

What desktop files?

All is mentioned in Koi/src/resources/(resources.qrc) and there is already a koi.desktop file inside Koi/src.

Right. Everything is there.

Finally submitted void-linux/void-packages#47985 PR

@MartinVonReichenberg MartinVonReichenberg added the Suggestion All kinds of suggestions label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion All kinds of suggestions
Projects
None yet
Development

No branches or pull requests

2 participants