New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show card resource icons instead of 'RES' in the corner. #3637
Conversation
If the CSS copying can be resolved (or accepted as a copy, eyyuch), this would be good to go. |
I agree, swapping the order is nicer. Will do. |
src/styles/cards_v2.less
Outdated
background-size: 22px; | ||
vertical-align: middle; | ||
} | ||
.card-resource-microbe { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can try to reduce code repetition by using lesscss each keyword like this:
@resource_types: microbe, animal, science;
each(@resource_types, {
.card-resource-@{value} {
background-image: url("./assets/resources/@{value}.png");
}
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh neat.
I love this! Have you checked that if one of these same cards like Security Fleet is on Self-Rep Robots that it doesn't accidentally show up as being fighter resources in that situation? It should look like blank white squares. |
I have not checked SRR. I almost never play or test with promos. But it seems worth checking before applying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/styles/cards_v2.less
Outdated
background-size: 22px; | ||
vertical-align: middle; | ||
} | ||
.card-resource-microbe { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh neat.
I removed the "prototype" from the definition because of satisfactory CSS reduction. |
I don't like copying the CSS. I wonder if
less
can help here.