Use libresolv to initialize cares on iPhone targets #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjasny
force-pushed
the
iphone-libresolv
branch
from
6792933
to
19690c2
Compare
|
Added check for strdup return value. |
gjasny
force-pushed
the
iphone-libresolv
branch
from
19690c2
to
29ffcaf
Compare
On iPhone targets like iOS, watchOS or tvOS the file /etc/resolv.conf cannot be used to configure cares. Instead the resolver library is queried for configuration values. CC: Yury Kirpichev <ykirpichev@yandex-team.ru>
gjasny
force-pushed
the
iphone-libresolv
branch
from
29ffcaf
to
b2326ad
Compare
|
Thanks, I've pulled that change in (with a trvial tweak to break out of the loop on strdup failure). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iPhone targets like iOS, watchOS or tvOS the file
/etc/resolv.conf cannot be used to configure cares.
Instead the resolver library is queried for configuration
values.
This patch has successfully been tested with any combination of IPv4 and IPv6 name servers.
Theoretically the libresolv code path could also be used on OS X.