Don't override ARES_OPT_DOMAINS with the values in resolv.conf #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please send the patch to the mailing list for review/discussions |
|
Please post your patch(es) to the mailing list so that you get your necessary reviews and acks, as otherwise they won't be merged: http://c-ares.haxx.se/mail/c-ares-archive-2014-05/0000.shtml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that since commit 125b1a8, "domains" and "search" lines in resolv.conf are overriding search domains set by the ARES_OPT_DOMAINS option.
This patch fixes init_by_resolv_conf to get the old behaviour back where ARES_OPT_DOMAINS options take priority, but still makes the last "domain" or "search" resolv.conf entry take priority over the first if the user didn't pass in any ARES_OPT_DOMAINS.