patch for undefined CURLE_OBSOLETE16 #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't get it. Why do you need CURLE_OBSOLETE16 ? Are you building an app that also uses a VERY old libcurl |
|
The patch makes it consistent with other obsolete/re-used error codes. Plus, it'll be easier to fix here than the 6000+ repos that refer to CURLE_FTP_CANT_RECONNECT. |
|
Gah, that's a lot! And there's in fact even more references to CURLE_OBSOLETE16 ... I think that convinces me to take the careful route forward and do as you suggest! |
bagder
pushed a commit
that referenced
this pull request
Jul 28, 2014
Removing defines, even obsolete ones that haven't been used for a very long time, still break a lot of applications. Bug: #106
|
Merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.