Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update landscape plot #20

Merged
merged 2 commits into from Mar 14, 2023
Merged

Update landscape plot #20

merged 2 commits into from Mar 14, 2023

Conversation

mBarreau
Copy link
Contributor

@mBarreau mBarreau commented Mar 9, 2023

The current landscape plot is a plot recipe. However, the argument l is already in used for the linewidth size, conflicting thus with the size of the landscape plot. This is not easily possible to draw several times the same landscape so a seed has been added.
Here are the proposed modifications:

  • The argument l is changed to lnorm
  • There is a random generator introduced if the seed argument is provided.

The tests have been updated and seemingly better looking landscape command has been added to the readme (together with the reference to the original paper proposing this method).

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.15 🎉

Comparison is base (02a8f03) 95.40% compared to head (a7e1d42) 95.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   95.40%   95.55%   +0.15%     
==========================================
  Files           2        2              
  Lines          87       90       +3     
==========================================
+ Hits           83       86       +3     
  Misses          4        4              
Flag Coverage Δ
unittests 95.55% <87.50%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/FluxOptTools.jl 91.11% <87.50%> (+0.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@baggepinnen baggepinnen merged commit da0dcce into baggepinnen:master Mar 14, 2023
2 of 3 checks passed
@mBarreau mBarreau deleted the update_landscape_plot branch March 15, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants