Implement Reorder Functionality of existing placed order #3132

vishalkushwaha94 · 2020-05-28T08:08:39Z

Hi
This is Vishal Kushwaha from Agra.
I have received an email from Webkul to complete a task of Reorder functionality in bagisto.
I do some changes in code to achieve my goal of reorder functionality so please review my changes.
I have also attache my task pdf that i received in email for reference

Reorder Feature.pdf

rahulcs0082 · 2020-05-29T07:30:20Z

Hello @vishalkushwaha94

We highly appreciate your work and effort but there are some changes that you need to do so that we can review your PR for functional purpose.

First of all, we are using multilanguage for this project so you need to write translation for each language instead of English only.

Kindly follow the PSR-2 coding standard. Please go through the given link and update code according to this standard - https://www.php-fig.org/psr/psr-2/ and https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md

vishalkushwaha94 · 2020-05-31T09:07:16Z

I have translated keywords in all language but there are some languages in which i can't find the exact translation of keyword like "Reorder" so in that case it is in English and also updated my code according to PSR-2 Standard.

While adding translation of keyword in Shop Module language file i find some strange things like there is one keyword which is used as title for cancel button, It is not present in every language file. I find it strange that's why i mention it here.

shubhwebkul · 2020-06-09T09:22:05Z

Hi Vishal,

Please add support for default theme too.
design issue.

vishalkushwaha94 · 2020-06-10T18:13:31Z

Hi Shubham,
Both issues have been resolved.

jitendra-webkul · 2020-06-11T05:40:56Z

packages/Webkul/Shop/src/Http/Controllers/OrderController.php

+            $slugOrPath = strtolower(str_replace(" ","-",$item->name));
+            $product = $this->productRepository->findBySlug($slugOrPath);
+
+            if(!$product->isSaleable()){


use space after ! operator

jitendra-webkul · 2020-06-11T05:41:36Z

packages/Webkul/Shop/src/Http/Controllers/OrderController.php

-        return view($this->_config['view'], compact('order'));
+        foreach ($order->items as $item) {
+            $slugOrPath = strtolower(str_replace(" ","-",$item->name));
+            $product = $this->productRepository->findBySlug($slugOrPath);


You can directly get product from $item. (Example $item->product)

Thanks for your tip it help me to reduce no of line in my code.

jitendra-webkul · 2020-06-11T05:42:04Z

packages/Webkul/Shop/src/Http/Controllers/OrderController.php

@@ -61,6 +73,7 @@ public function index()
     */
    public function view($id)
    {
+        $can_reorder = true;


Please Camel case here

jitendra-webkul · 2020-06-11T05:42:38Z

packages/Webkul/Shop/src/Http/Controllers/CartController.php

+        ]);
+
+        foreach ($order->items as $item) {
+            $slugOrPath = strtolower(str_replace(" ","-",$item->name));


Use space after and before with binary operator

jitendra-webkul · 2020-06-11T05:42:50Z

packages/Webkul/Shop/src/Http/Controllers/CartController.php

+        foreach ($order->items as $item) {
+            $slugOrPath = strtolower(str_replace(" ","-",$item->name));
+            $product = $this->productRepository->findBySlug($slugOrPath);
+            Cart::addProduct($product->product_id, ['product_id'=>$product->product_id,'quantity'=>$item->qty_ordered]); 


Use space after and before with binary operator

jitendra-webkul · 2020-06-11T05:43:02Z

packages/Webkul/Shop/src/Http/Controllers/CartController.php

    )
    {
-        $this->middleware('customer')->only(['moveToWishlist']);
+        $this->middleware('customer')->only(['moveToWishlist','reorder']);


Use space after and before with binary operator

jitendra-webkul · 2020-06-11T05:44:09Z

packages/Webkul/Velocity/src/Resources/views/shop/customers/account/orders/view.blade.php

                            {{ __('shop::app.customer.account.order.view.cancel-btn-title') }}
                        </a>
                    </span>
                @endif
+                @if (core()->getConfigData('customer.settings.reorder.product_reorder'))
+                    @if($can_reorder)


Use space after if and Use camel case for $can_reorder

vishalkushwaha94 · 2020-06-15T05:40:58Z

I have tried to resolve all the mentioned issues. Please let me know if there are any remaining.

vaishaliwebkul · 2020-06-16T10:44:20Z

@vishalkushwaha94
check reorder functionality with all product type
i.e; getting an exception when trying to reorder a configurable product

vishalkushwaha94 · 2020-06-17T10:50:12Z

@vaishaliwebkul

I have resolved error in reorder functionality with all product type if there is any one remaining please let me know.

vaishaliwebkul · 2020-06-18T14:51:34Z

Hi @vishalkushwaha94
It's now fixed for all product type :)

I am getting the error alert when reordering configurable product two times from the same order id

vishalkushwaha94 · 2020-06-19T07:18:50Z

@vaishaliwebkul

I have resolved the error please let me know if there are any remaining.

vaishaliwebkul · 2020-06-19T10:07:17Z

@vishalkushwaha94
can you please check the reorder for event booking type, as I am getting this error when place reorders for event booking even quantity are available

vishalkushwaha94 · 2020-06-19T13:49:07Z

@vaishaliwebkul
I hope this time i have resolved all issues, but please let me know if there are any remaining.

vaishaliwebkul · 2020-06-19T14:14:08Z

@vishalkushwaha94
Thanks for the efforts, but the last issue is still not resolved, can you please check again.

vishalkushwaha94 · 2020-06-20T11:35:12Z

@vaishaliwebkul
I have already solved the last issue, please check again and also share the screenshot of the error message as I am not facing any errors while reorder event booking.

vaishaliwebkul · 2020-06-22T07:26:13Z

Hi @vishalkushwaha94
I have updated my code with commit and check multiple times for this issue but always showing the same result.
Hope this will help you https://www.loom.com/share/40190127d6f245e9afc93410c3cd11c3

vishalkushwaha94 · 2020-06-22T16:37:36Z

Hi @vaishaliwebkul
Thanks for your response, I have resolved the issue, so please check and let me know if there are any issues remaining

vishalkushwaha94 · 2020-06-24T05:43:27Z

Hi @vaishaliwebkul

If you face any kind of error in reorder functionality please let me know i will resolve it as soon as possible.

vaishaliwebkul · 2020-06-24T06:13:54Z

Hi @vishalkushwaha94
you could also fix one more issue, follow the below steps:

place order for the rental booking(daily basis)
reorder this order( working fine)
now edit the same product for an hourly basis and save
reorder the previously order again

vishalkushwaha94 · 2020-06-24T07:51:08Z

Hi @vaishaliwebkul
Thanks for your response, but I would like to know that only this issue is left or there are others because if you face any other issues please mention here, this will help me to resolve them once.

vaishaliwebkul · 2020-06-24T08:37:41Z

@vishalkushwaha94
I have tested this functionality with the possible cases, all issues have been reported here
Finally, the last one also is resolved :)

Thanks.

ghermans · 2020-07-30T20:21:50Z

@vishalkushwaha94 can you please resolve the conflicted file packages/Webkul/Shop/src/Resources/views/customers/account/orders/view.blade.php ?

otheriz · 2020-09-18T06:09:46Z

Just a quick question..

Is this PR already read the availability of the stock?
what will happen if one or some of the 'reorder' items is have no stock?

Any alert or something?

vishal-webkul · 2020-09-23T05:11:24Z

Reorder option is not available if some of the 'reorder' items is have no stock.

ghermans · 2021-02-05T17:30:21Z

I am closing this PR since there has been no activity since 23 Sep 2020.

Implement Reorder Functionality of existing placed order

8ab08ed

jitendra-webkul requested a review from rahulshukla-webkul May 28, 2020 09:37

vishalkushwaha94 added 3 commits May 31, 2020 13:48

add transaltion of keyword in all lang file

02f0d06

change one variable name

eeaf385

fix issue which create problem while adding product in cart

2c33aa5

Design issue resolve and add support for default theme also

3f537e9

jitendra-webkul requested a review from shubhwebkul June 11, 2020 05:39

jitendra-webkul reviewed Jun 11, 2020

View reviewed changes

All mentioned issue resolved

9f86f6a

vishalkushwaha94 requested a review from jitendra-webkul June 16, 2020 06:10

Reorder functionality checked with all product type.

418878e

resolved mention error

e4533ec

Resolved booking type event issue and deleted product issue

2cb7db3

Event booking issue resolved

4fe82be

Issue resovled

6efa1f9

vishal-webkul and others added 2 commits August 6, 2020 12:03

Merge branch 'master' into vishal_kushwaha

27f769a

Merge branch 'master' into vishal_kushwaha

a12d6e7

ghermans closed this Feb 5, 2021

Implement Reorder Functionality of existing placed order #3132

Implement Reorder Functionality of existing placed order #3132

Conversation

vishalkushwaha94 commented May 28, 2020

rahulcs0082 commented May 29, 2020

vishalkushwaha94 commented May 31, 2020

shubhwebkul commented Jun 9, 2020

vishalkushwaha94 commented Jun 10, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vishalkushwaha94 commented Jun 15, 2020

vaishaliwebkul commented Jun 16, 2020

vishalkushwaha94 commented Jun 17, 2020

vaishaliwebkul commented Jun 18, 2020

vishalkushwaha94 commented Jun 19, 2020

vaishaliwebkul commented Jun 19, 2020

vishalkushwaha94 commented Jun 19, 2020

vaishaliwebkul commented Jun 19, 2020

vishalkushwaha94 commented Jun 20, 2020 • edited

vaishaliwebkul commented Jun 22, 2020

vishalkushwaha94 commented Jun 22, 2020

vishalkushwaha94 commented Jun 24, 2020

vaishaliwebkul commented Jun 24, 2020

vishalkushwaha94 commented Jun 24, 2020 • edited

vaishaliwebkul commented Jun 24, 2020

ghermans commented Jul 30, 2020 • edited

otheriz commented Sep 18, 2020

vishal-webkul commented Sep 23, 2020

ghermans commented Feb 5, 2021

vishalkushwaha94 commented Jun 20, 2020 •

edited

vishalkushwaha94 commented Jun 24, 2020 •

edited

ghermans commented Jul 30, 2020 •

edited