Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The add slider should be clickable in the image carousel on the admin panel. #8447

Closed
1 task done
Amitk-webkul opened this issue Sep 20, 2023 · 2 comments
Closed
1 task done
Assignees
Labels
2.x 2.x Versions Bug Fixed When bug issue is fixed. Bug Something isn't working.

Comments

@Amitk-webkul
Copy link
Collaborator

Terms

  • Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

master

Issue Description

If there is no link in the default simulation the add button should be clickable. The add slider should be clickable in the image carousel on the admin panel.

Preconditions

  1. Admin should be logged in.
  2. Delete all the default sliders in the image carousel.

Steps to reproduce

  1. Go to 'Admin panel'
  2. Click on 'Edit image carousel' inside the settings
  3. Delete all the sliders
  4. Click on the add slider button
  5. See the error

Expected Result

It should be clickable and should open the add slider pop-up.

Actual Result

it is not clickable. Here

Screenshots

No response

Additional context

No response

@Amitk-webkul Amitk-webkul added Bug Something isn't working. 2.x 2.x Versions labels Sep 20, 2023
@shivendra-webkul
Copy link
Collaborator

Already fixed in PR #8441

@shivendra-webkul shivendra-webkul added the Bug Fixed When bug issue is fixed. label Sep 20, 2023
@shivendra-webkul shivendra-webkul self-assigned this Sep 20, 2023
@Amitk-webkul
Copy link
Collaborator Author

Now, the button is removed because a single button will appear. so I am closing this issue.
And I have attached a screenshot Here, for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x 2.x Versions Bug Fixed When bug issue is fixed. Bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants