Skip to content
This repository has been archived by the owner on Aug 27, 2023. It is now read-only.

Support for Swift 5.6 #1

Closed
wants to merge 1 commit into from
Closed

Support for Swift 5.6 #1

wants to merge 1 commit into from

Conversation

daveverwer
Copy link

Hi Jhonatan!

I’d love to add both of these packages (SwiftSafeURL and
XcodeIssueReporting) to the Swift Package Index. Unfortunately we currently don’t support Swift 5.7 packages as it’s still in beta. However, I checked by building them locally with 5.6 and I don’t think you’re using any 5.7 specific features?

Would you consider these PRs to reduce the tools version?

Thanks!

@jhonatn
Copy link
Owner

jhonatn commented Jul 25, 2022

Hi Dave! I can drop that requirement, to be honest I can't remember why I introduced it in the first place. That said, remember that Swift Package Plugins compatibility is something that is only being run on Xcode 14, which is on beta for now, and that feature is key for this package to accomplish its objective

I dropped the Swift version to 5.5 over at 42c6b6c. Hope this helps!

@daveverwer
Copy link
Author

Thanks, Jhonatan!

to be honest I can't remember why I introduced it in the first place.

If you created the package with Xcode 14 beta it will have inserted 5.7 by default!

I dropped the Swift version to 5.5 over at 42c6b6c. Hope this helps!

It does, and the package is now safely in the index. However, 5.6 might be a better choice than 5.5. Swift plugins were introduced with 5.6 so I think that would be a better version to indicate full compatibility. I think the 5.5 indicator is actually what's causing all of the compatibility builds to fail, like you can see here:

https://swiftpackageindex.com/baguio/SwiftSafeURL/builds

The decision is entirely yours on which version of the tools to specify, but I think you'll get some better compatibility results using 5.6.

@daveverwer daveverwer closed this Jul 25, 2022
@jhonatn
Copy link
Owner

jhonatn commented Jul 28, 2022

It's weird that it is not giving me problems with 5.5, but you're correct. I pushed the Swift version back to 5.6, and the build results at SPI are looking just as expected. Thanks for pointing that out

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants