Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

feat: add typescript support #95

Merged
merged 3 commits into from Dec 15, 2021
Merged

feat: add typescript support #95

merged 3 commits into from Dec 15, 2021

Conversation

bahmutov
Copy link
Collaborator

@bahmutov bahmutov commented Dec 14, 2021

closes #94

馃毃 BLOCKED by bahmutov/find-test-names#8

@Narretz
Copy link
Contributor

Narretz commented Dec 15, 2021

Correct me if I'm wrong, but does the test actually make sure typescript is parsed? Because it will run the specs if parsing fails, right?

You could redirect the output of cypress-expect to a text file, and then verify "Could not determine test names in file: ts-spec.ts" is not in it.

@bahmutov
Copy link
Collaborator Author

I mean, nothing even is necessary - if it fails to parse it (like in this case if there is interface or type in the TS code), it simply runs the TS spec and relies on the runtime it overwrite to get the title and tags and skip the tests, it will be just unexpected empty spec. Not the worst thing in the world, and some specs would work correctly.

@bahmutov
Copy link
Collaborator Author

Ok, it is probably better than nothing!

@bahmutov bahmutov merged commit dde8275 into main Dec 15, 2021
@github-actions
Copy link

馃帀 This PR is included in version 2.12.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TS filter
2 participants