Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On windows, "missing README.md file" message when running grunt-nice-package unit tests #17

Closed
ludoviclefevre opened this issue Aug 12, 2015 · 2 comments
Labels

Comments

@ludoviclefevre
Copy link

Hi,

On windows 8, when running grunt-nice-package unit-tests, i get "missing README.md file" error message. Of course, this file is present.

I think the problem is related to glob issue: isaacs/node-glob#123

and getReadmeFiles function:

function getReadmeFiles() {
  var fileMatchOptions = {
    nocase: true
  };
  var readmes = glob.sync(process.cwd() + '/readme.md', fileMatchOptions)
      .concat(glob.sync(process.cwd() + '/readme', fileMatchOptions));
  return readmes;
}

In glob, process.cwd is the default directory in which to search. So a workaround could be

  var readmes = glob.sync('readme.md', fileMatchOptions)
      .concat(glob.sync('readme', fileMatchOptions));

I tried and it works on windows.

Your opinion?

Thanks.

Ludovic

@bahmutov
Copy link
Owner

Could you try version 0.9.3 for this problem, please?

@bahmutov bahmutov added the bug label Aug 12, 2015
@ludoviclefevre
Copy link
Author

I tried version 0.9.3 but I had the same problem. I think your package is not the problem, the root cause is in node-glob (isaacs/node-glob#123). When the node-glob issue will be fixed, it will resolve this problem.

Thank you for your time.

Ludovic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants