Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The page is insecure and does not have Push #1

Open
bahmutov opened this issue Jan 4, 2017 · 5 comments
Open

The page is insecure and does not have Push #1

bahmutov opened this issue Jan 4, 2017 · 5 comments
Labels

Comments

@bahmutov
Copy link
Owner

bahmutov commented Jan 4, 2017

See deployed to Zeit https://http2-push-example-mrcimnzfrc.now.sh/_logger for example

listening on port 8010
serving home
No HTTP/2 Push :(, is page secure? false
@bahmutov
Copy link
Owner Author

bahmutov commented Jan 5, 2017

Successfully deployed h2 to https://http2-push-example-tofygqqlwj.now.sh/
Need to run spdy server with options

const plainOptions = {
  spdy: {
    plain: true,
    ssl: false
  }
}

spdy.createServer(plainOptions, app).listen(8010, err => {
  if (err) {
    throw new Error(err)
  }
  console.log('listening on port 8010')
})

@jakearchibald
Copy link

https://http2-push-example-tofygqqlwj.now.sh/ doesn't seem to be pushing anything. Am I missing something?

@bahmutov
Copy link
Owner Author

bahmutov commented Mar 8, 2017 via email

@bahmutov
Copy link
Owner Author

bahmutov commented Mar 8, 2017

Hi Jake!
I failed to deploy this demo to Zeit, due to Nginx not supporting server push (which apparently is hard feature for a proxy to implement, since it requires keeping the channel open for long time), see the complete blog post with my actions at https://glebbahmutov.com/blog/server-push-on-dokku/

In a nut shell, had to use another proxy and my own server instance. No large gains for pushing a few images, should have pushed many small files instead to save on http handshake costs.

@jakearchibald
Copy link

Ahh gotcha, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants