Add restore option #99
Conversation
Some tests may want to use the natural system environment but then restore it completely after the test (so that any environment variables added during the test get removed). Adding a 'restore' option allows for this.
|
I like this option, but would like to see a test added |
this feature adds a restore option that if passed will restore the process.env environment when the restore() function is called. This varies from the current "clear" functionality as it does not clear the current environment when mockedEnv is called.
|
Tests added. Do you want me to rebase the branch as there are commits that don't pass lint. |
|
I also took the liberty of adding TypeScript definitions. |
| ) | ||
| }) | ||
|
|
||
| it('has default env, BANG, FOO and BAR', () => { |
There was a problem hiding this comment.
hmm, I am not sure this is the best test for this. We want to check "restore" right? So we probably better do
const restore = mockedEnv({...}, {restore: true})
process.env.BANG = 'bash'
restore()
la(process.env.BANG === undefined, 'did not restore process.env')
what do you think?
There was a problem hiding this comment.
That test only verifies that the environment variable that was present before mocking the environment was available during the mock when "restore" is given.
The later test "pass 'restore' in options" actually tests the case you're referring to where it changes the variable via process.env after mocking then verifies it restores it after.
There was a problem hiding this comment.
I see what you mean, merging your PR now
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Some tests may want to use the natural system environment but then restore it completely after the test (so that any environment variables added during the test get removed). Adding a 'restore' option allows for this.