Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design search bar on all pages desktop/mobil #41

Closed
martinheppner opened this issue Jun 15, 2023 · 9 comments
Closed

Design search bar on all pages desktop/mobil #41

martinheppner opened this issue Jun 15, 2023 · 9 comments
Assignees
Labels
Milestone

Comments

@martinheppner
Copy link
Contributor

martinheppner commented Jun 15, 2023

The search bar is working as it should at the moment. The design has to be adapted on desktop and mobil version to match the figma design (https://www.figma.com/file/qM4hoaxmGrrEEuTv4lL2lD/zuugle-redesign-2023-v3.0?type=design&node-id=0-1&t=g3UdMU8w26zmTY3s-0)

image

@martinheppner martinheppner added this to the Drop Slovenia milestone Jun 15, 2023
@Falsal
Copy link
Collaborator

Falsal commented Jul 4, 2023

pending issues after the push on 4th July:

  1. the space below the search bar, too high, a decrease of 10% of the height.
  2. the position of the serach bar should be matching the figma design, i.e. same level of search bar on the overlay with the search bar on the original search bar.
  3. width of inout area inside the search fields.
  4. Abbrechen cross does not remove the overlay
  5. the GO button does not take me to next page Main

@Falsal
Copy link
Collaborator

Falsal commented Jul 4, 2023

The "Main.js" view (listing all tours)

  1. check the dimensions on figma for the menubar (height of the bar)
  2. No tours appear below the bar.

@Falsal
Copy link
Collaborator

Falsal commented Jul 5, 2023

pending issues after the push on 5th July:

  1. position of the seach bar: almost done/ see attached screenshot
  2. width of input area inside the search fields: pending

Main.js:

  1. No tours appear below the bar. / need to retain the original FUNCTIONALITY before changes were made

Image

@Falsal
Copy link
Collaborator

Falsal commented Jul 6, 2023

Pending after push of 6th June:

position of the seach bar: almost done/ see attached screenshot
width of input area inside the search fields: pending

@Falsal
Copy link
Collaborator

Falsal commented Jul 6, 2023

Functionality should be moved to another issue.

@Falsal
Copy link
Collaborator

Falsal commented Jul 6, 2023

I moved the functionality to #55 with myself FALSAL assigned to it.

@Falsal
Copy link
Collaborator

Falsal commented Jul 6, 2023

The design on the MOBILE is not done.

@Falsal
Copy link
Collaborator

Falsal commented Jul 17, 2023

Search bar design-wise was done on the detail page but the design of remaining items on the page broke, this took some work on consolidating the App.css file original with Basit created one. Now it design is done except for the last buttons of download that needs a CSS fix
After that just need to wire the search bar up with search functionality, that should be another ticket, I will create it now.

@martinheppner
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants