Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.$validator.validateAll() is not working correctly anymore #658

Closed
Mouvedia opened this issue Jul 24, 2017 · 6 comments
Closed

this.$validator.validateAll() is not working correctly anymore #658

Mouvedia opened this issue Jul 24, 2017 · 6 comments
Labels
🐛 bug Unintended behavior

Comments

@Mouvedia
Copy link

Mouvedia commented Jul 24, 2017

Versions:

  • VueJs: 2.2.2
  • Vee-Validate: 2.0.0-rc.7

Description:

In short if I switch to rc.5, this.$validator.validateAll() correctly checks all fields' validity states.
In rc.7 errors.has gets triggered while this.$validator.validateAll() passes, which is obviously wrong.

Steps To Reproduce:

Pick a page with multiple validated fields (all with names, v-validate and v-model attributes) that uses this.$validator.validateAll() in rc.5 and try it out in rc.7.

@Mouvedia Mouvedia changed the title this.$validator.validateAll() is not working correctly anymore this.$validator.validateAll() is not working correctly anymore [regression] Jul 24, 2017
@logaretm logaretm added the 🐛 bug Unintended behavior label Jul 24, 2017
@logaretm
Copy link
Owner

I can confirm there are situations where it does not work properly any more, I will look into it when PR #616 is merged since it introduces plenty of fixes for the pipeline.

@Mouvedia
Copy link
Author

Mouvedia commented Jul 26, 2017

@logaretm now that it has been merged can you take a look at it?
I would like to upgrade because of #609 and #519.

PS: thanks for 54d00c1

@logaretm
Copy link
Owner

@Mouvedia So far the docs are working fine with validateAll locally, can you provide me with a fiddle? or you can test the latest built file and report back.

@Mouvedia
Copy link
Author

Mouvedia commented Jul 26, 2017

can you provide me with a fiddle?

For my peculiar case, not until Monday.
Anyhow here's a boilerplate https://www.webpackbin.com/bins/-Kq-UgP_l-mZgJmGaSZI so that others that are affected will be able to chip in.

@ThomHurks
Copy link
Contributor

@Mouvedia I expanded on your webpackbin some more, but couldn't get it to break:
https://www.webpackbin.com/bins/-Kq17kqOtMtGtP5RtNZ0
I don't know the specifics of your bug, so you'd have to add more details.

What you can also do is test your code with the master branch and check if it works now:
https://rawgit.com/logaretm/vee-validate/master/dist/vee-validate.js

@Mouvedia Mouvedia changed the title this.$validator.validateAll() is not working correctly anymore [regression] this.$validator.validateAll() is not working correctly anymore [invalid] Jul 27, 2017
@Mouvedia Mouvedia changed the title this.$validator.validateAll() is not working correctly anymore [invalid] this.$validator.validateAll() is not working correctly anymore Jul 27, 2017
@Mouvedia
Copy link
Author

@logaretm I am 80% sure that it's an error on my part. I didn't read the rc6 CHANGELOG when I upgraded from rc5 to rc7 and didn't see the breaking changes. The reason behind this oversight: you didn't respect semver.

Ill close this issue Monday once Ill confirm my hunch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants