New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this.$validator.validateAll() is not working correctly anymore #658
Comments
I can confirm there are situations where it does not work properly any more, I will look into it when PR #616 is merged since it introduces plenty of fixes for the pipeline. |
@Mouvedia So far the docs are working fine with validateAll locally, can you provide me with a fiddle? or you can test the latest built file and report back. |
For my peculiar case, not until Monday. |
@Mouvedia I expanded on your webpackbin some more, but couldn't get it to break: What you can also do is test your code with the master branch and check if it works now: |
@logaretm I am 80% sure that it's an error on my part. I didn't read the rc6 CHANGELOG when I upgraded from rc5 to rc7 and didn't see the breaking changes. The reason behind this oversight: you didn't respect semver. Ill close this issue Monday once Ill confirm my hunch. |
Versions:
Description:
In short if I switch to rc.5,
this.$validator.validateAll()
correctly checks all fields' validity states.In rc.7
errors.has
gets triggered whilethis.$validator.validateAll()
passes, which is obviously wrong.Steps To Reproduce:
Pick a page with multiple validated fields (all with names, v-validate and v-model attributes) that uses
this.$validator.validateAll()
in rc.5 and try it out in rc.7.The text was updated successfully, but these errors were encountered: