Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the essential comments in project #13

Open
qzhai opened this issue Jul 26, 2018 · 3 comments
Open

add the essential comments in project #13

qzhai opened this issue Jul 26, 2018 · 3 comments

Comments

@qzhai
Copy link

qzhai commented Jul 26, 2018

i found the code understanding is very difficult, could you help add some essential comments?

@liuhaomin
Copy link
Collaborator

I am sorry that current readability is not good enough. We are working on it but it will take some time. What kind of comments do you think is most essential? I guess we will do that first.

@qzhai
Copy link
Author

qzhai commented Aug 8, 2018

hi, Haomin, thanks for reply.
I think the comments of basic data structure, the class member and the core algorithm which includes local and global BA is very important to understand the code and algorithm, thanks all of you a lot.

@J2eremy
Copy link

J2eremy commented Nov 29, 2018

Hi, how is this work coming along?
It's really difficult to understand the code without comments especially in local and global BA.
For example, the comments of variable naming rules in LocalBundleAdjustor.h will help a lot.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants