Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify specific resource configs, they're redundant now #14

Closed
m3ngyang opened this issue Nov 12, 2018 · 2 comments
Closed

simplify specific resource configs, they're redundant now #14

m3ngyang opened this issue Nov 12, 2018 · 2 comments
Assignees

Comments

@m3ngyang
Copy link
Member

configs of different resource are redundant now, for example

https://github.com/baidu/baiducloud-sdk-go/blob/develop/eip/client.go#L12

// Config of eip
type Config struct {
	*bce.Config
}

https://github.com/baidu/baiducloud-sdk-go/blob/develop/bos/client.go#L27

// Config of bos
type Config struct {
	*bce.Config
}
@m3ngyang
Copy link
Member Author

Specific resources, such as eip, vpc, bos, etc, share the same config struct of bce, to construct their own clients. @wccsama @cwdsuzhou @hello2mao

@m3ngyang
Copy link
Member Author

close by #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants