Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrangler app bad substitution error #37

Closed
arisp99 opened this issue Apr 27, 2022 · 1 comment
Closed

Wrangler app bad substitution error #37

arisp99 opened this issue Apr 27, 2022 · 1 comment
Labels
bug unexpected problem or unintended behavior
Milestone

Comments

@arisp99
Copy link
Member

arisp99 commented Apr 27, 2022

Bug Description

In #26, we implemented checks to ensure that arguments passed to the wrangler app had no spaces in them. Our solution relies on parameter expansion. Crucially, this is a non-POSIX feature. While our container does run using bash, this error would indicate that the parameter expansion is not working properly.

Reported by @iek.

@arisp99 arisp99 added the bug unexpected problem or unintended behavior label Apr 27, 2022
@arisp99 arisp99 added this to the 1.0.0 milestone Apr 27, 2022
@arisp99
Copy link
Member Author

arisp99 commented Apr 27, 2022

Not being able to perform parameter expansions causes errors in other places as well. The lines that need to be fixed are:

MIPTools/MIPTools.def

Lines 409 to 420 in d3e613c

# Remove whitespace from arguments
probe_sets=${probe_sets//[[:space:]]/}
sample_sets=${sample_sets//[[:space:]]/}
stitch_options=${stitch_options//[[:space:]]/}
# Ensure that stitch options begin with a comma if not the default value
# This is done as the arguments are fed in with leading dashes and the
# python script will crash if dashes are fed in. By adding a leading comma,
# the script will run.
if [ ${stitch_options:0:1} != "," ] && [ ${stitch_options} != "none" ]; then
stitch_options=",${stitch_options}"
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant