-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression for lower bound al of binary search #7
Comments
@liarrn I think the difference between the code and the paper is that in the paper |
@BAILOOL Thank you for the quick reply! int exp1 = rows + cols + 2*numRetPoints;
long long exp2 = ((long long) 4*cols + (long long)4*numRetPoints + (long long)4*rows*numRetPoints + (long long)rows*rows + (long long) cols*cols - (long long)2*rows*cols + (long long)4*rows*cols*numRetPoints);
double exp3 = sqrt(exp2);
double exp4 = (2*(numRetPoints - 1));
double sol1 = -round((exp1+exp3)/exp4); // first solution
double sol2 = -round((exp1-exp3)/exp4); // second solution
int high = (sol1>sol2)? sol1 : sol2; //binary search range initialization with positive solution
int low = floor(sqrt((double)keyPoints.size()/numRetPoints)); |
@liarrn You are right. I think I have made a copy-paste mistake when preparing code for this repository since the original version we used for the experiments in the paper was too messy to deal with. Thank you for pointing it out. |
In the paper, the al=sqrt(n/m)/2, while in the code implementation, e.g. line 303 of anms.h, the al is calculated as
int low = floor(sqrt((double)keyPoints.size()/numRetPoints));
. Could the author clarify the discrepancy?The text was updated successfully, but these errors were encountered: