Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page not being broken on suspected whitespace #32

Closed
bajuwa opened this issue Mar 15, 2020 · 1 comment
Closed

Page not being broken on suspected whitespace #32

bajuwa opened this issue Mar 15, 2020 · 1 comment
Assignees
@bajuwa
Labels
bug Something isn't working Comicom The main Comic Compiler script that performs the stitching Needs Retesting For bugs that have to be retested/verified after other large changes

Comments

@bajuwa
Copy link
Owner

bajuwa commented Mar 15, 2020

Under ./test/default image40.jpg appears to end in whitespace, but does not 'break' at that point (adding colour error does not resolve the issue).
Test with imagemagick directly to see if the bottom of the image is actually pure white. If not, test with an increased standard deviation to see if that fixes the problem.
@bajuwa bajuwa added bug Something isn't working Comicom The main Comic Compiler script that performs the stitching labels Mar 15, 2020
@bajuwa bajuwa added the Needs Retesting For bugs that have to be retested/verified after other large changes label Apr 3, 2020
@bajuwa
Copy link
Owner Author

bajuwa commented Apr 5, 2020

Verified that increasing the error tolerance and standard deviation causes the pages to break on
image

@bajuwa bajuwa closed this as completed Apr 5, 2020
@bajuwa bajuwa self-assigned this Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bajuwa bajuwa

Labels
bug Something isn't working Comicom The main Comic Compiler script that performs the stitching Needs Retesting For bugs that have to be retested/verified after other large changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bajuwa