Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change breakpoint detection to work off of proper colours instead of grayscale #66

Open
bajuwa opened this issue Apr 5, 2020 · 0 comments
Labels
Argument Involves adding/modifying one of the arguments for the main command line script Comicom The main Comic Compiler script that performs the stitching documentation Improvements or additions to documentation enhancement New feature or request Testing For anything that requires new or updated automated tests

Comments

@bajuwa
Copy link
Owner

bajuwa commented Apr 5, 2020

Currently we use 16bit grayscale decimal values as 'input colours'. This is limited and not very user friendly, so we should change to colour values that people will actually recognize and cover the full spectrum of pixel colours that could be seen.

See here for updated imagemagick command: https://www.imagemagick.org/discourse-server/viewtopic.php?t=11725

convert rose: -scale 1x1! -format "%[fx:floor(255*u.r)],%[fx:floor(255*u.g)],%[fx:floor(255*u.b)]" info: returns 145,89,80

Converting 16bit grayscale decimal can be done by converting to 8bit decimal via x = (65535 >> 8) and then using the output x of 0-255 value to get rgb(x,x,x)

This will require changes to the command line argument inputs to accept RGB/dec/gray based input formats:

  • #hexcode
  • rgb(#,#,#)
  • dec(###)
  • gray(0-65535) [this will be the full version of the current input of just an integer]
@bajuwa bajuwa added documentation Improvements or additions to documentation enhancement New feature or request Comicom The main Comic Compiler script that performs the stitching Argument Involves adding/modifying one of the arguments for the main command line script Testing For anything that requires new or updated automated tests labels Apr 5, 2020
@bajuwa bajuwa added question Further information is requested and removed question Further information is requested labels Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argument Involves adding/modifying one of the arguments for the main command line script Comicom The main Comic Compiler script that performs the stitching documentation Improvements or additions to documentation enhancement New feature or request Testing For anything that requires new or updated automated tests
Projects
None yet
Development

No branches or pull requests

1 participant