Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to cancel the currently running compilation #72

Open
bajuwa opened this issue Apr 10, 2020 · 2 comments
Open

Add an option to cancel the currently running compilation #72

bajuwa opened this issue Apr 10, 2020 · 2 comments
Labels
ComGUI A GUI wrapper to Comicom enhancement New feature or request help wanted Extra attention is needed

Comments

@bajuwa
Copy link
Owner

bajuwa commented Apr 10, 2020

After hitting 'run', replace the word 'run' with 'cancel' and have it interrupt the scripts.
@bajuwa bajuwa added enhancement New feature or request ComGUI A GUI wrapper to Comicom labels Apr 10, 2020
@bajuwa
Copy link
Owner Author

bajuwa commented Apr 11, 2020

This is turning out to be non-trivial as python cannot kill the threads it creates, and when trying to use processes the 'pickle' package it depends on does not work with the current implementation.

@bajuwa
Copy link
Owner Author

bajuwa commented Apr 22, 2020 •
edited
Loading

consider triggering the script via shell instead via Popen which has Popen.kill()

nvm, the comgui.exe won't have access to a script to trigger via popen

@bajuwa bajuwa added the help wanted Extra attention is needed label Apr 22, 2020
@bajuwa bajuwa removed this from the v1.1.2 - Usability Upgrades milestone Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ComGUI A GUI wrapper to Comicom enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bajuwa