Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL for Web UI #327

Closed
smarthome-enthusiast opened this issue Apr 3, 2024 · 4 comments · Fixed by #329
Closed

SSL for Web UI #327

smarthome-enthusiast opened this issue Apr 3, 2024 · 4 comments · Fixed by #329
Labels
enhancement New feature or request

Comments

@smarthome-enthusiast
Copy link

Is your feature request related to a problem? Please describe.

I'm trying to have the web UI displayed on HomeAssistant through an iFrame but I'm unable to load HTTP inside a HTTPS web server.

Describe the solution you'd like*

Would it be possible to support SSL? Maybe through the environment variables on docker file, we could specify the certificate and key and enable SSL on the same port.

Describe alternatives you've considered

Disabling HTTPS on HomeAssistant but that would make it very insecure during remote access.

Anything else?

No response

@smarthome-enthusiast smarthome-enthusiast added the enhancement New feature or request label Apr 3, 2024
@bakito bakito mentioned this issue Apr 6, 2024
4 tasks
@bakito
Copy link
Owner

bakito commented Apr 6, 2024

Hi @smarthome-enthusiast
Thank you for the feature request.

I can offer you the following:

  1. The tls cert files have to be mounted as volume into the Container.
  2. The location and names of the certs can be defiend via env variables.
    Check https://github.com/bakito/adguardhome-sync/blob/tls-mode/README.md?plain=1#L176 and support api tls mode #329

@smarthome-enthusiast
Copy link
Author

This would be fantastic.

@bakito
Copy link
Owner

bakito commented Apr 8, 2024

@smarthome-enthusiast
Copy link
Author

smarthome-enthusiast commented Apr 8, 2024

Just updated and it work. Thank you for the quick work and all the work you have done on this!

Edit: just had another look at the logs, I'm getting this error "http: TLS handshake error from 192.168.1.230:33184: EOF" (Replica DNS server) every minute after syncing. It retries 5 times than stops until the next sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants