Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New log duration (6hrs) breaks sync if selected #49

Closed
gf78 opened this issue Jan 9, 2022 · 1 comment
Closed

New log duration (6hrs) breaks sync if selected #49

gf78 opened this issue Jan 9, 2022 · 1 comment

Comments

@gf78
Copy link

gf78 commented Jan 9, 2022

Describe the bug
At least from AdGuard version 0.107.2 on the storage duration for logs can be set to 6hrs (0.25 days). If 6hrs are selected - even if logging is disabled at all - the sync fails with the following error:

ERROR sync sync/sync.go:143 Error getting query log config {"from": "x.x.x.x:xxxx", "error": "json: cannot unmarshal number 0.25 into Go struct field QueryLogConfig.interval of type int"}

To Reproduce
Steps to reproduce the behavior:

  1. What version of AdGuardHome sync used? quay.io/bakito/adguardhome-sync, ID c3dbf3ea71c8
  2. What version of AdGuardHome us used? 0.107.2
  3. How does the configuration look? 6hrs logging period
  4. What is the error message? see above

Expected behavior
Support the new setting, change the used data format from int to float.

Log Files
see above

Additional context
none

@bakito bakito closed this as completed in 5cd27f4 Jan 9, 2022
@bakito
Copy link
Owner

bakito commented Jan 9, 2022

Thank you for reporting this issue.

It is fixed in vesion https://github.com/bakito/adguardhome-sync/releases/tag/v0.4.0

Please be aware, that origin and replicas must have AdGuard Home >= v0.107.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants