This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
Activate sound when the volume is changed (even in silent mode) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent mode (kind of like Snapchat). This is reset when video is closed, so volume must be changed again when new video starts if the user wants sound
|
@3lvis want to take a look? ;) |
3lvis
reviewed
Jan 1, 2017
| try AVAudioSession.sharedInstance().setCategory(AVAudioSessionCategoryPlayback, with: []) | ||
| } | ||
| catch let error { | ||
| print("Failed to start playback sound: \(error.localizedDescription)") |
There was a problem hiding this comment.
We should probably handle the errors as we are doing it in other places.
https://github.com/bakkenbaeck/Viewer/blob/master/Source/VideoView.swift#L91-L92
There was a problem hiding this comment.
Yes, but I was thinking about this as an "non-fatal" error, so I don't want it to fail the video playing. Or should it?
3lvis
reviewed
Jan 1, 2017
| audioSession.addObserver(self, forKeyPath: VideoView.audioSessionVolumeKeyPath, options: .new, context: nil) | ||
| self.shouldRegisterForOutputVolume = false | ||
| } catch { | ||
| print("Failed to activate audio session") |
There was a problem hiding this comment.
Same comment about error handling, here, too.
|
@askeland Nice fix! Only comment is regarding error handling, otherwise looks 👍 |
|
Yes, I was a little unsure about the error handling. Kind of just wanted to make it fail silently since it isn't exactly a critical feature |
|
@askeland I see now :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activate sound when the volume is changed even if phone is in silent mode (kind of like Snapchat). This is reset when video is closed, so volume must be changed again when new video starts if the user wants sound