Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdbtool merge generates XML with version 3 #109

Closed
faxm0dem opened this issue Mar 13, 2014 · 2 comments
Closed

pdbtool merge generates XML with version 3 #109

faxm0dem opened this issue Mar 13, 2014 · 2 comments
Labels
enhancement in progress
Milestone
syslog-ng 3.5.6

Comments

@faxm0dem
Copy link
Contributor

In my understanding, pdbtool should merge the versions of individual files with the following logic:

  • fail when there is a version mismatch (or use highest, if backwards compatible)
  • use the provided version if all files have the same version

See: https://github.com/balabit/syslog-ng/blob/master/modules/dbparser/pdbtool/pdbtool.c#L314-L315
@faxm0dem faxm0dem mentioned this issue Apr 17, 2014
Merged
@algernon algernon added this to the syslog-ng 3.5.5.1 milestone Jul 31, 2014
@algernon
Copy link
Contributor

Within the scope of 3.5, I can make merge set the version to v4. In 3.6, we can likely do better, and follow the logic suggested... or at least, use the provided version if all versions match, and fail if there's a mismatch.

With the current code, detecting compatibility would be quite a pain, so I'd rather default to failing on mismatch.

algernon added a commit that referenced this issue Aug 4, 2014
@algernon
dbparser: Update XML version to 4 in pdbtool merge
7a69819 
When merging patterndb files, output patterndb version 4 XML. This
partially addresses #109.

Requested-by: Fabien Wernli
Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
@algernon
Copy link
Contributor

algernon commented Aug 7, 2014

Closing for now, as pdbtool merge now emits v4 patterndb files.

@algernon algernon closed this as completed Aug 7, 2014
@bazsi bazsi mentioned this issue Feb 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement in progress
Projects
None yet
Milestone
syslog-ng 3.5.6
Development

No branches or pull requests
2 participants
@algernon @faxm0dem