Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/filter/filter-cmp.c:116: missing break ? #772

Closed
dcb314 opened this issue Nov 10, 2015 · 1 comment · Fixed by #774
Closed

lib/filter/filter-cmp.c:116: missing break ? #772

dcb314 opened this issue Nov 10, 2015 · 1 comment · Fixed by #774
Assignees

Comments

@dcb314
Copy link

dcb314 commented Nov 10, 2015

[lib/filter/filter-cmp.c:116] -> [lib/filter/filter-cmp.c:118]: (warning) Variable 'cmp_op' is reassigned a value before the old one has been used. 'break;' missing?

Source code is

case KW_NUM_LT:
  self->cmp_op = FCMP_NUM;
case KW_LT:
  self->cmp_op = FCMP_LT;
  break;
@ihrwein
Copy link
Contributor

ihrwein commented Nov 10, 2015

Thanks for reporting the issue!

Maybe its just a missing break but I suspect we should do something like this:

case KW_NUM_LT:
  self->cmp_op = FCMP_NUM | FCMP_LT;
  break;
case KW_LT:
  self->cmp_op = FCMP_LT;
  break;

I'll do the change. @bazsi Could you verify me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants