--with-libmongo-client option does not have auto choice.

[mitzkia]

And it's default parameter is internal(aka git submodule), which is not fortunate if you are a distro packager. (mostly you want to use the system libmongo-client library).

[bazsi]

Are we sure we want to accommodate distro packagers over individuals compiling syslog-ng? Wouldn't we need the same default for all submodules?

Just asking, I have no objections if you have a strong opinion here. In case you do just go ahead and merge it.

Thanks

[algernon]

It actually helps individuals more than distro packagers (distro packagers have been using --with-libmongo-client=system since day one, pretty much), because they don't need to wonder why it's not picking up the system library. The change also makes the behaviour less confusing. And finally: promoting the use of system libraries is a Good Thing.

I do agree that we should do something similar with the other submodules too, where we can. I'll submit a separate pull request that does it for ivykis.

The third submodule we have is rabbitmq-c, where we don't support using the system library at all, so that'll remain as it is.

[bazsi]

Are we sure we want to accommodate distro packagers over individuals compiling syslog-ng? Wouldn't we need the same default for all submodules?

Just asking, I have no objections if you have a strong opinion here. In case you do just go ahead and merge it.

Thanks