Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The zone file parser does not support Tzif3 files #86

Closed
algernon opened this issue Feb 19, 2014 · 1 comment · Fixed by #88
Closed

The zone file parser does not support Tzif3 files #86

algernon opened this issue Feb 19, 2014 · 1 comment · Fixed by #88
Assignees
Labels
Milestone

Comments

@algernon
Copy link
Contributor

As the title says: the zone file parser does not support tzif3 format files, which is produced by zic >= 2013. This causes test case failures on at least Fedora.

The updated manpage says:

For version-3-format time zone files, the POSIX-TZ-style string may use
two minor extensions to the POSIX TZ format, as described in
newtzset(3).  First, the hours part of its transition times may be
signed and range from -167 through 167 instead of the POSIX-required
unsigned values from 0 through 24.  Second, DST is in effect all year
if it starts January 1 at 00:00 and ends December 31 at 24:00 plus the
difference between daylight saving and standard time.

Originally reported by Peter Czanik czanik@balabit.hu

@algernon algernon added the bug label Feb 19, 2014
@algernon algernon self-assigned this Feb 19, 2014
@algernon
Copy link
Contributor Author

This will need the following changes:

  • Allow version 3 at the top of zone_info_parser()
  • Allow gmt_offsets between -167 and 167 in v3 (currently it's 0-24)

As far as I see, we ignore DST anyway, so that part need not be changed.

@algernon algernon added this to the 3.5.4 milestone Feb 21, 2014
algernon added a commit that referenced this issue Feb 21, 2014
The latest tzdata release added a new tzif version, with some minor
changes. This patch adds support for the format to our zone info parser,
and fixes #86.

Reported-by: Peter Czanik <czanik@balabit.hu>
Signed-off-by: Gergely Nagy <algernon@balabit.hu>
@bazsi bazsi closed this as completed in #88 Feb 21, 2014
algernon added a commit that referenced this issue May 20, 2014
The latest tzdata release added a new tzif version, with some minor
changes. This patch adds support for the format to our zone info parser,
and fixes #86.

Reported-by: Peter Czanik <czanik@balabit.hu>
Signed-off-by: Gergely Nagy <algernon@balabit.hu>
gdani pushed a commit to gdani/syslog-ng that referenced this issue May 30, 2014
The latest tzdata release added a new tzif version, with some minor
changes. This patch adds support for the format to our zone info parser,
and fixes syslog-ng#86.

Reported-by: Peter Czanik <czanik@balabit.hu>
Signed-off-by: Gergely Nagy <algernon@balabit.hu>
juhaszviktor pushed a commit that referenced this issue Mar 30, 2015
The latest tzdata release added a new tzif version, with some minor
changes. This patch adds support for the format to our zone info parser,
and fixes #86.

Reported-by: Peter Czanik <czanik@balabit.hu>
Signed-off-by: Gergely Nagy <algernon@balabit.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant