H/parse number 32bit bigendian fix #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using glong causes potential portability issues as somewhere it is 64bits, on other platforms it is only 32 bits. The lexer, which uses the parse-number functions, stores the return value in gint64, that is always 64 bits, so use that always. Reported-By: Tamayo, Andres <Andres.Tamayo@viasat.com> Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
parse-number had an issue on 32 bit big endian platforms, make sure it is actually working with 64 bit values, always by adding a testcase that expects a 64 bit value. Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
|
Looks good to me, merged both patches to 3.5. |
bazsi
added a commit
that referenced
this pull request
Mar 10, 2014
H/parse number 32bit bigendian fix
HofiOne
pushed a commit
to HofiOne/syslog-ng
that referenced
this pull request
Jun 10, 2024
autotools: fix pkg* paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a configuration parsing issue on 32 bit big endian systems.