java-modules: report location information only when 'loglevel <= DEBUG' #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requesting location information (class name, method name, line number) is a slow operation, this should be displayed only in DEBUG (and TRACE) mode. Signed-off-by: László Várady <laszlo.varady@balabit.com>
kvch
reviewed
Oct 26, 2016
| } | ||
| else { | ||
| StringBuilder formatedMessage = new StringBuilder(); | ||
| formatedMessage.append(event.getLocationInformation().getClassName()); |
There was a problem hiding this comment.
nitpicking: is not it cleaner to create a list for part of the formatted message and then loop over that list and append it to formattedMessage?
There was a problem hiding this comment.
LocationInfo doesn't implement the Iterable or Collection interface, so I would have to add the message parts one by one to the list. I think this is the same ugly logic as the current one.
kvch
approved these changes
Oct 26, 2016
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting location information (class name, method name, line number) is a slow operation, this should be displayed only in DEBUG (and TRACE) mode.