ack_tracker: keep AckTracker parent class 64 bit aligned #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AckTracker is a parent "class" for LateAckTracker which contains a RingBuffer. RingBuffer has a pointer member which points to the memory where the AckRecord slots (containing Bookmark) are stored. When the AckTracker is unaligned then the RingBuffer within LateAckTracker will also be unaligned and that can lead to SIGBUS on Sparc and IA64 platforms. Signed-off-by: Budai Laszlo <Laszlo.Budai@balabit.com>
algernon
added a commit
that referenced
this pull request
Jul 22, 2014
ack_tracker: keep AckTracker parent class 64 bit aligned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AckTracker is a parent "class" for LateAckTracker which contains a RingBuffer.
RingBuffer has a pointer member which points to the memory where the AckRecord
slots (containing Bookmark) are stored.
When the AckTracker is unaligned then the RingBuffer within LateAckTracker
will also be unaligned and that can lead to SIGBUS on Sparc and IA64 platforms.
Signed-off-by: Budai Laszlo Laszlo.Budai@balabit.com