Emit less confusing warnings for diskq #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the word "omitted" may be confusing, as it sounds like something should have been there, but was not taken into account. Let's use "ignored" instead, as for something that *should not* be there in the first place (and therefore was ignored). Also be more verbose and suggest the other configuration parameter. Fixes syslog-ng#1733. Signed-off-by: Jakub Jankowski <shasta@toxcorp.com>
|
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? (admin please type: ok to test) |
|
@kira-syslogng ok to test |
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
Kokan
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the word "omitted" may be confusing, as it sounds like something should have been there, but was not taken into account. Let's use "ignored" instead, as for something that should not be there in the first place (and therefore was ignored).
Also be more verbose and suggest the other configuration parameter.
Fixes #1733.