Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the loggen.c license from GPL to LGPL [skip-ci] #2006

Merged
merged 1 commit into from May 7, 2018

Conversation

norberttak
Copy link
Contributor

Signed-off-by: norberttakacs norbert.takacs@balabit.com

@norberttak norberttak changed the title Modify the loggen.c licencse from GPL to LGPL Modify the loggen.c license from GPL to LGPL [skip-ci] Apr 27, 2018
Copy link
Collaborator

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(There is a typo in the commit message)

@kira-syslogng
Copy link
Contributor

failure

Signed-off-by: norberttakacs <norbert.takacs@balabit.com>
@bazsi
Copy link
Collaborator

bazsi commented Apr 27, 2018

All main executables in syslog-ng has been licensed under the LGPL and not the GPL, so this in principle is in the right direction.

Pls allow me to check contributors of that code:

As I see this has been entirely been authored by Balabit employees, except for two lines by @ibmibmibm. I guess those authors are ok with the change.

The lines authored by @ibmibmibm are: 1) a free() call and (2) a close() call, both to fix a resource leak (one is a memory leak, the other is an fd leak). These are introduced by these patches:

commit c2dc2c6
Author: Shen-Ta Hsieh ibmibmibm.tw@gmail.com
Date: Tue Jan 16 17:19:50 2018 +0800

loggen: fix potential leak on strdup variable

Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>

commit f6fcd7e
Author: Shen-Ta Hsieh ibmibmibm.tw@gmail.com
Date: Tue Jan 16 17:15:42 2018 +0800

loggen: fix potential leak on socket fd

Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>

I do not consider those lines to be copyrightable, based on these articles:

https://en.wikipedia.org/wiki/Idea%E2%80%93expression_divide
http://guides.lib.umich.edu/copyrightbasics/copyrightability
https://meta.wikimedia.org/wiki/Wikilegal/Sweat_of_the_Brow

Basically, there's only one way to free() a memory area or to close() an fd, thus "modicum of creativity" is not reached.

With that explanation, this is signed-off-by and approved by me.

@ibmibmibm I hope you agree with my explanation and are ok with the change from GPL to LGPL.

@Kokan Kokan merged commit 242c87d into syslog-ng:master May 7, 2018
@norberttak norberttak deleted the loggen-relicense branch May 30, 2018 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants