fix static uClibc-ng support #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of static uClibc-ng lib, the <dlfcn.h> does not exists. The signal-handler.c solves an issue in case of program src/dst and Java destination. That combination is really rare if not impossible. This patch simply disables own sigaction if <dlfcn.h> is not present. Signed-off-by: Kokan <kokaipeter@gmail.com>
|
Build SUCCESS |
|
@Kokan this fixes the build failure. Thanks. |
|
@Kokan the changeset itself looks good to me. About java+program destination: do you think it would be useful to add a configure/cmake time check, so that when |
|
@furiel I was thinking about it, but compiling those modules are fine, even using them in a different syslog-ng instance are ok; using only a warning could be a way, but imho won't be noticed. If you or anybody still think a warning would be nice, I can update the patch accordingly. |
|
@Kokan I agree warning is not necessary here. |
furiel
approved these changes
Jan 21, 2019
lbudai
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of static
uClibc-nglib, the<dlfcn.h>does not exists.The
signal-handler.csolves an issue in case ofprogramsrc/dstand
Javadestination. That combination is really rare if not impossible.This patch simply disables own
sigactionif<dlfcn.h>is not present.Fixes #2491
@cpackham could you test with this patch, if any other issue is present ?