value-pairs: Ignore empty values in SDATA too #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value-pairs framework ignored empty values when they were explicitly specified as such, but when they came through via SDATA or any other means, it treated them as empty strings, and allowed them through. This was inconsistent, and a waste too. This patch corrects that behaviour, and empty-valued SDATA members will not pass through anymore. Reported-by: Lucas McLane <lucas@clicksecurity.com> Signed-off-by: Gergely Nagy <algernon@balabit.hu>
bazsi
added a commit
that referenced
this pull request
Dec 5, 2013
value-pairs: Ignore empty values in SDATA too
szemere
pushed a commit
to szemere/syslog-ng
that referenced
this pull request
Jul 2, 2020
bazsi
pushed a commit
to bazsi/syslog-ng
that referenced
this pull request
May 17, 2024
axosyslog: add scl.conf to scl package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value-pairs framework ignored empty values when they were explicitly
specified as such, but when they came through via SDATA or any other
means, it treated them as empty strings, and allowed them through. This
was inconsistent, and a waste too.
This patch corrects that behaviour, and empty-valued SDATA members will
not pass through anymore.
Reported-by: Lucas McLane lucas@clicksecurity.com
Signed-off-by: Gergely Nagy algernon@balabit.hu