update according to clang, gcc diagnostic differences, and fix newly found issues #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build SUCCESS |
alltilla
reviewed
Jul 1, 2019
|
Build FAILURE Build FAILURE |
|
Build FAILURE |
|
@kira-syslogng retest this please |
|
Build SUCCESS |
furiel
previously approved these changes
Jul 10, 2019
| @@ -74,7 +74,6 @@ AM_CFLAGS += \ | |||
| -Wall \ | |||
| -Wuninitialized \ | |||
| -Wunused-but-set-parameter \ | |||
| -Wcast-align \ | |||
There was a problem hiding this comment.
Do we want to drop this entirely or plan to fix this later? In the latter case, you might open a jira issue for it.
| return; | ||
| } | ||
|
|
||
| cr_assert(fabs(a-b) < G_MINDOUBLE); |
There was a problem hiding this comment.
Me feels G_MINDOUBLE too small, but have no better idea. Nonetheless it is equivalent change this way. Later we might want to pass this as a parameter if we run into trouble due to precision.
The `-Wmissing-parameter-type` is accepted by gcc (not by clang), despite that it does not do anything since C99. In such cases a `-Wimplicit-int` warning is triggered, thus replacing the current warning with the new. Signed-off-by: Kokan <kokaipeter@gmail.com>
Signed-off-by: Kokan <kokaipeter@gmail.com>
Signed-off-by: Kokan <kokaipeter@gmail.com>
Signed-off-by: Kokan <kokaipeter@gmail.com>
This warning was never fixed, but gcc is take the ABI into account when reporting alignment issue. In case of x86 those are not actual issues, thus gcc silence. On the other hand clang reports it despite of arch. Also additionally the most issue is related to *sockaddr* casting, and some magic inside syslog-ng related to nv-pairs (both are probably okay on arm as well). Signed-off-by: Kokan <kokaipeter@gmail.com>
Signed-off-by: Kokan <kokaipeter@gmail.com>
The *INFINITY* is defined as float by default, but according to C99 standard it still should be fine to mean infinite in case of double as well. Signed-off-by: Kokan <kokaipeter@gmail.com>
Add a new *cr_assert_gdouble_eq* to compare gdoubles. Signed-off-by: Kokan <kokaipeter@gmail.com>
Signed-off-by: Kokan <kokaipeter@gmail.com>
Signed-off-by: Kokan <kokaipeter@gmail.com>
Signed-off-by: Kokan <kokaipeter@gmail.com>
First of all the `-Wsuggest-attribute=noreturn` is only supported by `gcc`, a better option would be `-Wmissing-noreturn` which is supported by `gcc` and `clang` as well. As the current standard the project follows is C99, there is no standard way, to conform with this warning (only gcc-ism). C11 provides `_Noreturn` keyword to save the day. I do not consider this warning that that important, as there is warning for function with non-void functions, this only handles methods that does not return (terminates the executable). Additionally the current flex 2.5.35 (used in travis) generates a code that does not conform with `-Wmissing-noreturn` (does not use the needed attribute). Newer version fixed this behaviore (2.6). I would only enable this warning when C11 is the used standard, by that time I hope flex newer version is also updated most of the places. Signed-off-by: Kokan <kokaipeter@gmail.com>
Signed-off-by: Kokan <kokaipeter@gmail.com>
|
Build FAILURE |
alltilla
reviewed
Jul 12, 2019
alltilla
approved these changes
Jul 15, 2019
|
@kira-syslogng retest this please |
|
Build SUCCESS |
furiel
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main focus was on
cmake+clang, sorryautotools.Changes that were to replace/remove a warning was also changed in the
autotools.But a few option was removed in case of
clangasclangdoes not define them, and those were not updated inautotools(in case ofautotoolsthose warnings must be turned on via--enable-extra-warnings).Additionally I also turned on the extra warnings for
cmake+clangcombination.Note: it seems clang is able to detect issues even if they are hidden via macro usage, while gcc is unable to see such errors (anything written in macros gcc just fine with it).