logpipe: do not reset config when pipe is deinited #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two kind of initialization around log_pipes. One is log_pipe_init_instance(), a kind of constructor, which is called only once, when the object is constructed. And there is log_pipe_init() (and its corresponding pair, log_pipe_deinit()) which could be called several times on a construced object (eg.:during reload). Config is set by log_pipe_init_instance() but reset is called by log_pipe_deinit(). During reload we already have a constructed object in deinited state (config is set to NULL after deinit). When we call init() on such an object it will cause seg.fault because config is NULL. Signed-off-by: Budai Laszlo <Laszlo.Budai@balabit.com>
|
👍 |
|
Indeed, originally the config was assigned to the LogPipe using log_pipe_init(), thus its symmetric deinit was in log_pipe_deinit(). However the initialization went to the constructor, so it's a mistake to So that patch is great, thanks for diagnosing the problem. |
talien
added a commit
that referenced
this pull request
Oct 10, 2014
logpipe: do not reset config when pipe is deinited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two kind of initialization around log_pipes.
One is log_pipe_init_instance(), a kind of constructor, which is
called only once, when the object is constructed.
And there is log_pipe_init() (and its corresponding pair, log_pipe_deinit())
which could be called several times on a construced object (eg.:during reload).
Config is set by log_pipe_init_instance() but reset is called by
log_pipe_deinit().
During reload we already have a constructed object in deinited state
(config is set to NULL after deinit). When we call init() on such an object
it will cause seg.fault because config is NULL.
references:
#203
Signed-off-by: Budai Laszlo Laszlo.Budai@balabit.com