Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter: add new ipv6 netmask filter by "netmask6" tag #338

Merged
merged 1 commit into from
Jan 21, 2015
Merged

filter: add new ipv6 netmask filter by "netmask6" tag #338

merged 1 commit into from
Jan 21, 2015

Conversation

deirf
Copy link

@deirf deirf commented Dec 8, 2014

usage:
"ipv6address/prefix"
where
ipv6address = valid ipv6 address
prefix = integer number from 1 to 128

Signed-off-by: Fried Zoltan zoltan.fried@balabit.com

@bazsi
Copy link
Collaborator

bazsi commented Dec 8, 2014

The test case should probably have been cleaned up. Its OK this way but I would have used the opportunity to do a bit more low level test case, this way avoiding the integration test nature of test-filters.c

@lbudai
Copy link
Collaborator

lbudai commented Dec 9, 2014

filter_netmask6_new() and other ipv6 related stuff should be compiled only on those machines where ipv6 is supported ( #if ENABLE_IPV6 is missing from filter-netmask6.{h,c} )

usage:
	"ipv6address/prefix"
where
	ipv6address = valid ipv6 address
	prefix = integer number from 1 to 128

Signed-off-by: Fried Zoltan <zoltan.fried@balabit.com>
@deirf deirf added the ready label Jan 19, 2015
@lbudai lbudai removed the ready label Jan 19, 2015
lbudai added a commit that referenced this pull request Jan 21, 2015
filter: add new ipv6 netmask filter by "netmask6" tag
@lbudai lbudai merged commit 071e0ed into syslog-ng:master Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants