python: Fix the automake warnings in the Python module #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionally setting .PHONY makes automake very sad. Instead of doing that, include modules/python/pylib/Makefile.am unconditionally, and add ENABLE_PYTHON guards there, with the .PHONY dependencies moved out into an unconditional part. Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
|
👍 |
|
thanks! |
lbudai
added a commit
that referenced
this pull request
Jun 16, 2015
python: Fix the automake warnings in the Python module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally setting .PHONY makes automake very sad. Instead of doing
that, include modules/python/pylib/Makefile.am unconditionally, and add
ENABLE_PYTHON guards there, with the .PHONY dependencies moved out into
an unconditional part.
Signed-off-by: Gergely Nagy algernon@madhouse-project.org