configure: fix python related make distcheck problems #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When one runs make distcheck, configure is called without parameters like --enable-*, --with-*. Before this patch with_python didn't have default value and enable_python had 'auto'. We set the ENABLE_PYTHON condition when enable_python isn't 'no'. The problem was, that the enable_python variable wasn't set to 'no' when with_python was empty. As a consequence --with-python now accepts parameters, like --with-python=2, --with-python=2.7, --with-python=auto. The --with-python=yes case was removed, because --enable-python replaced this behavior. Signed-off-by: Tibor Benke <tibor.benke@balabit.com>
ihrwein
force-pushed
the
f/fix-python-related-distcheck-problems
branch
from
da27cab
to
4553115
Compare
|
I've rephrased the commit message. |
|
Thanks! 👍 |
lbudai
added a commit
that referenced
this pull request
Jun 19, 2015
…roblems configure: fix python related make distcheck problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was, that the enable_python variable wasn't set to 'no',
when with_python was 'no'.
--with-python now accepts parameters, like --with-python=2,
--with-python=2.7, --with-python=auto. The --with-python=yes case was
removed, because --enable-python replaced this behavior.
Signed-off-by: Tibor Benke tibor.benke@balabit.com