-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.6/f/json parser unit test #56
Conversation
There's still a segmentation fault in the test case. I see it on Travis, but have not tried it locally yet. |
I think
I suspect this may have to do something with Travis having json-c 0.9, while I have 0.11 locally. I'll try to reproduce it on a Precise chroot. |
modules/json builds libjson-plugin.la instead of simply libjson.la because of library name clashes (see b9125dd), however the per-subdirectory Makefile contained a heuristic to find out what to build at install time. This heuristic failed for modules/json/ as it didn't meet the convention, and this patch fixes that. Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
As that unit test only covers the $(format-json) template function. Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
As the unit tests don't cause the recompile the json plugin. Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
As we don't use that type for anything but the return type and causes additional casts on the call sites. Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
When a json-parser() is referenced from multiple points in the configuration, it is cloned. However the clone() operation could reference a NULL pointer if marker was not set. This patch fixes this issue. Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
Old versions of libjson-c used to store C NULL value in the returned struct json_object, which got dereferenced by json-parser. Although newer json-c versions seems to have fixed this issue (0.11 tested here) add a workaround for this case. Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
This patch implements a unit test for the json-parser() parser object. Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
For consistency with the rest of the syslog-ng codebase. Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>
I have updated a branch now with the following changes:
|
Nice catch with json-c! I skimmed through the patches, and they all look good. Fingers crossed for Travis thinking similarly. |
tools: add Criterion && Astyle description
AxoSyslog v4.5.0
No description provided.