json: do not rely on json_object_is_type() accepting NULL #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from jsonc 0.10, `json_object_is_type()` started handling NULL appropriately. With previous versions, calling this function with NULL would lead to a segfault. The version embedded in syslog-ng is recent enough. This fix is for people using `--with-jsonc=system` and having a too old system jsonc library (like the one in Ubuntu Precise).
| @@ -221,6 +221,8 @@ json_dot_notation_eval(JSONDotNotation *self, struct json_object *jso) | |||
| JSONDotNotationElem *compiled; | |||
| gint i; | |||
|
|
|||
| if (!jso) goto error; | |||
There was a problem hiding this comment.
Please put the goto into a separate line.
|
There is only one review note from me. If you fix that, I give you my 👍 Thanks :) |
vincentbernat
force-pushed
the
fix/jsonc-null
branch
from
82b135b
to
5897e20
Compare
|
Updated! |
|
Then 👍 |
|
👍 as well. FYI: json-c is only bundled to make it easier to use by users, Thanks for the patch. Bazsi On Tue, Jul 21, 2015 at 4:48 PM, Tibor Benke notifications@github.com
|
lbudai
added a commit
that referenced
this pull request
Jul 23, 2015
json: do not rely on json_object_is_type() accepting NULL
|
👍, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from jsonc 0.10,
json_object_is_type()started handling NULLappropriately. With previous versions, calling this function with NULL
would lead to a segfault.
The version embedded in syslog-ng is recent enough. This fix is for
people using
--with-jsonc=systemand having a too old system jsonclibrary (like the one in Ubuntu Precise).
I have experienced the "bug" in
json/json-parser.c. I think that the "bug" could also be triggered indot-notation.cbut I can't be sure. The test may be unneeded.Not using embedded libs is a common culture in distributions and is useful to get security updates (jsonc had several CVE fixes in the past). So, I think the use case is valid, but I can understand if it would be dismissed.