F/dbparser split into smaller modules #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove |
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
At one point an error struct was created but not returned as it should have, creating a leak and an unreported error. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Earlier both of the entries were stored in the same hash table, split them. Smaller hashes are better and this makes the key a bit simpler. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
This is just a skeleton of the correllation functionality to be encapsulated into a class. It is not just more than a wrapper around a hashtable. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
An instance of the CorrellationContext is used in the CorrellationState, making it possible to create distinct, correllation-like functionality. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
The role of the new class is to encapsulate a message that is being generated by syslog-ng itself. It is always generated based on another, triggering message, for instance it encapsulates the <message> actions within a db-parser() action. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Instead of open-coding this function in the pdb XML loader, extract it as a method. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
…struct This helps to hide some of the internals of PatternDB. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
As we have the broken-down header files, this is not needed anymore. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
As we always store CorrellationContext, we can free it using correllation_context_unref, thus we can make the API simpler. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
As the evaluation of patterndb rules were not extracted along into their data structs, those connect a bit more to PatternDB itself, so rename the methods accordingly. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
bazsi
force-pushed
the
f/dbparser-split-into-smaller-modules
branch
from
31e4376
to
d90d4cc
Compare
|
I have now fixed up the travis fallouts, so please merge. Thanks. |
|
Thanks for this refactor!! |
lbudai
added a commit
that referenced
this pull request
Aug 25, 2015
…dules F/dbparser split into smaller modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch splits up dbparser into smaller modules in order to make parts a bit more reusable. I was explicitly trying not to change functionality and all patches in the set individually pass "make check" in the modules/dbparser subdirectory.
Please merge
Thanks.