Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install fails to install patterndb xsds #684

Merged
merged 1 commit into from
Sep 11, 2015
Merged

make install fails to install patterndb xsds #684

merged 1 commit into from
Sep 11, 2015

Conversation

algernon
Copy link
Contributor

I recently started to update my Debian packaging, and noticed that when using the tarball release, after a ./configure && make && make install, the xsd files are not installed for some odd reason.

I have not tried building from a git checkout yet.

@czanik
Copy link
Collaborator

czanik commented Sep 9, 2015

AFAIR, xsd files are only installed, if --enable-manpages is used for
./configure

Peter Czanik (CzP) peter.czanik@balabit.com
BalaBit IT Security / syslog-ng upstream
http://czanik.blogs.balabit.com/
https://twitter.com/PCzanik

On Wed, Sep 9, 2015 at 5:11 PM, Gergely Nagy notifications@github.com
wrote:

I recently started to update my Debian packaging, and noticed that when
using the tarball release
https://github.com/balabit/syslog-ng/releases/download/syslog-ng-3.7.1/syslog-ng-3.7.1.tar.gz,
after a ./configure && make && make install, the xsd files are not
installed for some odd reason.

I have not tried building from a git checkout yet.


Reply to this email directly or view it on GitHub
#684.

@algernon
Copy link
Contributor Author

algernon commented Sep 9, 2015

Uhm... but those XSD files are not for validating patterndb files, they're not documentation, that's the doc/man/ stuff.

The problem may be somewhere else, because I see no relevant changes under doc since 3.6. I'll update this issue once I know more.

@algernon
Copy link
Contributor Author

Ok, turns out --enable-manpages fixes my problem, but it still does not feel right, XSDs are not man pages. So I'm leaving this open, in the hopes that in a future version, the flag will only apply to man pages instead of the whole of doc/, as it now seems.

@lbudai
Copy link
Collaborator

lbudai commented Sep 10, 2015

@algernon: you are right, those files are not manpages, this is definitely a bug

@faxm0dem
Copy link
Contributor

👍

Instead of skipping doc/ alltogether when ENABLE_MANPAGES is not set,
only skip the actual man pages, but handle the rest properly.

Closes #684.

Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
@algernon
Copy link
Contributor Author

Patch that supposedly fixes it is attached. I did some basic testing and it seems to work, but I didn't go to great lengths to verify every scenario. It should work, nevertheless.

@lbudai
Copy link
Collaborator

lbudai commented Sep 10, 2015

Travis build had failed due to some infrastructural issue, so I'm going to rerun the tests.

@lbudai
Copy link
Collaborator

lbudai commented Sep 11, 2015

I tried it: it is worked for me. Thanks!

lbudai added a commit that referenced this pull request Sep 11, 2015
make install fails to install patterndb xsds
@lbudai lbudai merged commit 5af36de into syslog-ng:master Sep 11, 2015
@lbudai lbudai removed the ready label Sep 11, 2015
@algernon algernon deleted the h/xsd-vs-manpages branch September 11, 2015 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants