F/dbparser code refinements #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods were already renamed, the struct was not, so do that in this patch. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Both in db-parser and in the upcoming correllate() parser we need two
data pointers in the timerwheel expiration callback:
1) one that relates to the entry being freed
2) one that is global to a TimerWheel, a PatternDB reference in the case
of db-parser() and a Correllate reference in correllate()
In db-parser() this was solved by adding an extra pointer to _all_
PDBContext entries. This is a lot of extra storage if there are 10s
of thousands of entries and is a circular dependency.
To resolve this an "associated data" pointer is added to TimerWheel,
which can be set and queried and is automatically destroyed when the
timerwheel is freed using a GDestroyNotify callback.
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Instead of adding the PatternDB reference to all PDBContext entries, use the associated_data mechanism in TimerWheel to store that. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
As we were invoking these from two call-sites (once in new/free and once in forget_state()), extract these into a separate function. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
|
If you are interested in correllate(), see my work-in-progress patches in f/correllate |
| void | ||
| stateful_parser_set_inject_mode(StatefulParser *self, const gchar *inject_mode) | ||
| { | ||
| self->inject_mode = stateful_parser_lookup_inject_mode(inject_mode); |
There was a problem hiding this comment.
Is the -1 value handled correctly in other places? The default is pass-through so I'd expect to fallback to that. stateful_parser_emit_synthetic() will create an internal message in this case.
There was a problem hiding this comment.
fixed in 33af212 by pushing the validation up to the parser.
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a couple of patches against dbparser that help the implementation of the upcoming correllate()
parser, a component that can do correllation with a similar model that we have in db-parser() but without the message parsing/matching logic.