Removing directives that split up parts of statements. #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #endif | ||
| ) | ||
| if(checker) | ||
| { |
There was a problem hiding this comment.
I agree with the change in general however, we should use better naming of this variable.
Also checker = msg->saddr completely disregards typing. So apart from the name it should be a Boolean.
And if we are at it, I would try to extract the ipv4 or ipv6 check to a separate function
|
Is that what you meant, @bazsi? |
…er follow project's guidelines.
|
This looks great now, now please merge the three patches into one and sign it off so I can merge it. Thanks. |
|
will you do the rebase or shall I do it? |
|
@bazsi, please do the rebase. I do not know exactly what to do. |
|
I am closing this in favour of pr #830 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion to compile entire statements and expressions, as suggested by code style guidelines from the Linux Kernel and practitioners.
It might improve code understanding, maintainability and error-proneness.