Log HTTP response error codes in HTTP destination

[MrAnno]

Fixes: #669

[bazsi]

This looks good to me, I was just wondering if we could make java logs a bit more integrated to syslog-ng internal logging style.

👍

[ihrwein]

👍

[lbudai]

@bazsi: you mean that we could use
this one:
HTTP response error; error_code ='404'
instead of this:
HTTP response code error: 404
?

It's doable. @MrAnno ?

[bazsi]

I am not sure how java generated log messages appear in general. But yeah,
that's what I meant, and just for this log message but all of them.

This is fine, the formatting should change as a whole in a unified manner.
On Jan 14, 2016 3:13 PM, "Budai Laszlo" notifications@github.com wrote:

@bazsi https://github.com/bazsi: you mean that we could use
this one:
HTTP response error; error_code ='404'
instead of this:
HTTP response code error: 404
?

It's doable. @MrAnno https://github.com/MrAnno ?

—
Reply to this email directly or view it on GitHub
#855 (comment).

[MrAnno]

Currently, the InternalMessageSender class enables to send messages with different priorities but without any tags.

JNIEXPORT void JNICALL
Java_org_syslog_1ng_InternalMessageSender_createInternalMessage(JNIEnv *env, jclass cls, jint pri, jstring message)
{
  if ((pri != org_syslog_ng_InternalMessageSender_MsgDebug) || debug_flag)
    {
      const char *c_str = (*env)->GetStringUTFChars(env, message, 0);
      msg_event_suppress_recursions_and_send(msg_event_create(pri, c_str, NULL));

      (*env)->ReleaseStringUTFChars(env, message, c_str);
    }
}

[bazsi]

I consider this an omission of the original implementation which should be
fixed. I wouldn't try to determine priorities when to do it, as there are
many things to improve and this is just one of them.

But java destinations should be just as integrated with syslog-ng as if
they were written in C.
On Jan 14, 2016 3:44 PM, "László Várady" notifications@github.com wrote:

Currently, the InternalMessageSender interface enables to send messages
with different priorities but without any tags.

msg_event_suppress_recursions_and_send(msg_event_create(pri, c_str, NULL));

—
Reply to this email directly or view it on GitHub
#855 (comment).

[MrAnno]

Oh, I see. I will create a new issue about this.

[lbudai]

I'd merge this as-is, then a new PR should fix the java logmessage formatting issue.

[bazsi]

I agree.

Bazsi

On Thu, Jan 28, 2016 at 4:12 PM, Budai Laszlo notifications@github.com
wrote:

I'd merge this as-is, then a new PR should fix the java logmessage
formatting issue.

—
Reply to this email directly or view it on GitHub
#855 (comment).

[ihrwein]

I've merged it but I forget to ask for a rebase. I hope that the master is OK.

[lbudai]

we will see... :-)

[bkil-syslogng]

The integration protection that I have outlined earlier would have both caught this, and assured us whether this would be safe.