Fix global option inheritance in unix socket sources #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAnno
changed the title
|
👍 |
MrAnno
force-pushed
the
afsocket-globalcfg-inher-fix
branch
from
f49162c
to
420e9ce
Compare
The global `create-dirs` option was not inherited in afunix-source
if the `options{};` block was positioned lower in the
configuration file than the given module declaration.
This commit fixes this issue by moving the "inheritance" assignment from
`afunix_sd_new_instance` to `afunix_sd_init`.
Signed-off-by: László Várady <laszlo.varady@balabit.com>
The global `pass-unix-credentials` option was not inherited in afunix-source
if the `options{};` block was positioned lower in the
configuration file than the given module declaration.
This commit fixes this issue by moving the "inheritance" assignment from
`afunix_sd_new_instance` to `afunix_sd_init`.
Signed-off-by: László Várady <laszlo.varady@balabit.com>
|
👍 , and thank you for the separated commits. |
|
👍 thanks! |
ihrwein
added a commit
that referenced
this pull request
Feb 3, 2016
Fix global option inheritance in afunix-source
|
👍 |
MrAnno
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #894
The global
create-dirsandpass-unix-credentialsoptions were notinherited in afunix-source if the
options{};block was positioned lower in theconfiguration file than the given module declaration.
This pull request fixes this issue by moving the "inheritance" assignment from
afunix_sd_new_instancetoafunix_sd_init.