Update native parser bindings #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihrwein
force-pushed
the
log-path-options
branch
from
899b124
to
c27080c
Compare
|
Somehow travis wants to test the second commit... Please wait with the merge. Note: I added the |
added 4 commits
March 23, 2016 15:30
The aim of this change is to improve the "portability" of LogPathOptions. A bitfield is a very C like concept, it's implementation compiler dependent. The log_pipe_forward_msg() function takes a LogPathOptions pointer, so if somebody wants to call it from an other language, the LogPathOptions type has to be redefined. If LogPathOptions contains bitfields, that could be a problem. I didn't find any performance penalty. We always pass around LogPathOptions pointers, so the only dramatic change is we lose some bytes on a stackframe. Signed-off-by: Tibor Benke <tibor.benke@balabit.com>
The original function is static inline, so we need to create a public alias for it. This approach certainly works on Linux systems. Signed-off-by: Tibor Benke <tibor.benke@balabit.com>
We may need that pointer during a parse. The previous solution was flawed because if the parser was cloned with clone(), the Rust parser didn't receive the parser at all. By passing the super pointer to each parse() call, we remove a state and guarantee, that the pointer is always valid (basically, it's a form of borrowing). Signed-off-by: Tibor Benke <ihrwein@gmail.com>
Signed-off-by: Tibor Benke <ihrwein@gmail.com>
ihrwein
force-pushed
the
log-path-options
branch
from
c27080c
to
3784647
Compare
|
Now it will test the last commit :) Again ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
LogPathOptionsto use booleans instead of bitfields (24ebce2)